mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70217: Implemented the remain functionalities for v0 `VolumeManager`.
Date Wed, 20 Mar 2019 22:30:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70217/#review213859
-----------------------------------------------------------




src/csi/v0_volume_manager.cpp
Lines 322 (patched)
<https://reviews.apache.org/r/70217/#comment299959>

    Since this is not run in any sequence, it is possible that the caller calls two `createVolume`
and do this twice, which could be potentially racing with e.g., `deleteVolume`.
    
    So we should bookkeep the volume names being created and avoid such a race before issuing
the CSI call:
    ```
    if (creating.contanis(name)) {
      return Failure("Volume with name '" + name + "' is being created");
    }
    ```
    
    Similar safe-guards should be implemented for `validateVolume` and `deleteVolume` as well.


- Chun-Hung Hsiao


On March 18, 2019, 2:53 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70217/
> -----------------------------------------------------------
> 
> (Updated March 18, 2019, 2:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch completes the `listVolumes`, `getCapacity`, `createVolume`,
> `deleteVolume` and `validateVolume` methods for the v0 `VolumeManager`.
> Compared to SLRP, `VolumeManager` now supports validating a volume that
> has already been mounted (say before the agent ID changes), as well as
> deleting unmanaged volumes.
> 
> 
> Diffs
> -----
> 
>   src/csi/v0_volume_manager.cpp PRE-CREATION 
>   src/csi/v0_volume_manager_process.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70217/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message