mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70247: Added an "unversioned" `VolumeCapability`.
Date Wed, 20 Mar 2019 14:09:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70247/#review213837
-----------------------------------------------------------



This looks reasonable to me, but I haven't seen yet that it can adapt to both csi-v0 and csi-v1.


include/mesos/csi/compat.hpp
Lines 1 (patched)
<https://reviews.apache.org/r/70247/#comment299912>

    Similar namespace suggestion as for the protos.



include/mesos/csi/compat.proto
Lines 1 (patched)
<https://reviews.apache.org/r/70247/#comment299910>

    I don't think these definitions need to be public as they never leave the agent. Let's
just add them to `src/csi/` or sim?



include/mesos/csi/compat.proto
Lines 19 (patched)
<https://reviews.apache.org/r/70247/#comment299909>

    Looking at https://reviews.apache.org/r/70248/ I see that the `VolumeCapability` we'd
actually want to use most of the time would always come from `compat`.
    
    Can we define it e.g., in `mesos.csi` or alternatively `mesos.csi.types` instead? That
would seem more natural to me.



include/mesos/csi/compat.proto
Lines 27-30 (patched)
<https://reviews.apache.org/r/70247/#comment299914>

    This promises a pretty hard thing. Why are we so sure this is always possible?
    
    This would be less concerning if this file would contain just types never leaving a single
node (i.e., no concerns about mixing different proto versions).
    
    Let's promise that we'll try to faithfully reconstruct types instead?



include/mesos/csi/compat.proto
Lines 35 (patched)
<https://reviews.apache.org/r/70247/#comment299906>

    I don't think we lint protobuf files with cpplint or clang-tidy.



include/mesos/csi/compat.proto
Lines 37 (patched)
<https://reviews.apache.org/r/70247/#comment299911>

    Let's move helpers and their tests for these types from https://reviews.apache.org/r/70248/
here.



src/csi/compat.cpp
Lines 25-61 (patched)
<https://reviews.apache.org/r/70247/#comment299913>

    `return google::protobuf::util::MessageDifferencer::Equals(left, right)`?


- Benjamin Bannier


On March 20, 2019, 7:15 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70247/
> -----------------------------------------------------------
> 
> (Updated March 20, 2019, 7:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9625
>     https://issues.apache.org/jira/browse/MESOS-9625
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To support both CSI v0 and v1, the "unversioned" `VolumeCapability` is
> designed to satisfy the following compatibility guarantees:
> 
> 1. It can be parsed from the JSON representation of a CSI v0 or v1
>    `VolumeCapability`. This is for making the `UriDiskProfileAdaptor`
>    backward compatible, and the profile service can simply provide
>    `VolumeCapability` of a specific CSI version without rework.
> 
> 2. The unversioned `VolumeCapability` parsed from a versioned one should
>    be able to used to reconstruct the original versioned
>    `VolumeCapability`, and can be upgraded/downgraded to a different
>    CSI version and preserve as much semantics as possible.
> 
> 3. If an backward-incompatible change is introduced in future CSI
>    `VolumeCapability`, the unversioned `VolumeCapability` can provide a
>    way to do a backward compatible upgrade.
> 
> 
> Diffs
> -----
> 
>   include/mesos/csi/compat.hpp PRE-CREATION 
>   include/mesos/csi/compat.proto PRE-CREATION 
>   src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
>   src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
>   src/csi/compat.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70247/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message