mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70250: Made hashmap::containsValue consistent with stout naming convention.
Date Wed, 20 Mar 2019 11:38:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70250/#review213832
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70249, 70250]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On March 20, 2019, 2:56 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70250/
> -----------------------------------------------------------
> 
> (Updated March 20, 2019, 2:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Benno Evers.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In stout we use snake case, not camel case.
> 
> This patch contains fixes to users in Mesos.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce 
>   src/slave/containerizer/docker.cpp fc29e20bedd37f77b9be49cedbb1012473abdfee 
>   src/slave/containerizer/mesos/launcher.cpp b38f88db4d120eb27ad56bdb7639cb80c76063d3

> 
> 
> Diff: https://reviews.apache.org/r/70250/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`, not a functional change
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message