mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70248: Adapted the unversioned `VolumeCapability`.
Date Wed, 20 Mar 2019 06:37:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.


Bugs: MESOS-9625
    https://issues.apache.org/jira/browse/MESOS-9625


Repository: mesos


Description
-------

This patch makes the disk profile adaptors and the CSI volume state
protobuf to use the unversioned `VolumeCapability` instead of the CSI v0
protobuf, so the profile adaptors and the volume state checkpoints can
be upgraded to support CSI v1 in a backward compatible way.


Diffs
-----

  include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc

  src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4 
  src/csi/utils.hpp 9145c6795c3ecdde5de5859a852763fe9aeb1ddf 
  src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc 
  src/csi/v0_volume_manager.hpp PRE-CREATION 
  src/csi/v0_volume_manager.cpp PRE-CREATION 
  src/csi/v0_volume_manager_process.hpp PRE-CREATION 
  src/csi/volume_manager.hpp PRE-CREATION 
  src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2 
  src/resource_provider/storage/disk_profile.proto 1c97e9c62fb3154d6048d0e55352a1276adcbca8

  src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a

  src/resource_provider/storage/disk_profile_utils.hpp 8a83a15ba555ce66bbb86b8df72178bce17a615a

  src/resource_provider/storage/disk_profile_utils.cpp 82c69d8b916a933f13e1185ffbf8ec65afd04ccf

  src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e

  src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9

  src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e 


Diff: https://reviews.apache.org/r/70248/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message