mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70247: Added an "unversioned" `VolumeCapability`.
Date Wed, 20 Mar 2019 06:15:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70247/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.


Bugs: MESOS-9625
    https://issues.apache.org/jira/browse/MESOS-9625


Repository: mesos


Description
-------

To support both CSI v0 and v1, the "unversioned" `VolumeCapability` is
designed to satisfy the following compatibility guarantees:

1. It can be parsed from the JSON representation of a CSI v0 or v1
   `VolumeCapability`. This is for making the `UriDiskProfileAdaptor`
   backward compatible, and the profile service can simply provide
   `VolumeCapability` of a specific CSI version without rework.

2. The unversioned `VolumeCapability` parsed from a versioned one should
   be able to used to reconstruct the original versioned
   `VolumeCapability`, and can be upgraded/downgraded to a different
   CSI version and preserve as much semantics as possible.

3. If an backward-incompatible change is introduced in future CSI
   `VolumeCapability`, the unversioned `VolumeCapability` can provide a
   way to do a backward compatible upgrade.


Diffs
-----

  include/mesos/csi/compat.hpp PRE-CREATION 
  include/mesos/csi/compat.proto PRE-CREATION 
  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
  src/csi/compat.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/70247/diff/1/


Testing
-------


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message