mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70168: Added `ServiceManager` to manage CSI plugin container lifecycles.
Date Wed, 20 Mar 2019 05:36:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/
-----------------------------------------------------------

(Updated March 20, 2019, 5:36 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Jan's and Benjamin's comments, and moved the metrics refactor to r/70245.


Bugs: MESOS-9632
    https://issues.apache.org/jira/browse/MESOS-9632


Repository: mesos


Description (updated)
-------

The `ServiceManager` will be used to refactor SLRP to move container
management out from SLRP. It is agnostic to CSI versions, so can be used
to manage plugin containers for both CSI v0 and v1 plugins. Most of its
logic are adapted from the SLRP code.


Diffs (updated)
-----

  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
  src/csi/service_manager.hpp PRE-CREATION 
  src/csi/service_manager.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/70168/diff/7/

Changes: https://reviews.apache.org/r/70168/diff/6-7/


Testing
-------

Testing done later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message