mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70245: Moved CSI plugin metrics out from SLRP metrics.
Date Wed, 20 Mar 2019 05:27:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70245/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Bugs: MESOS-9632
    https://issues.apache.org/jira/browse/MESOS-9632


Repository: mesos


Description
-------

This is a preliminary refactor patch for `ServiceManager` introduced in
the next patch. The CSI plugin metrics are moved out from SLRP metrics
object so the metrics can be accessed by `ServiceManager`. However, SLRP
still owns these metrics for now. Eventually we would like to decouple
metrics lifecycles from SLRP lifecycles.


Diffs
-----

  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
  src/csi/metrics.hpp PRE-CREATION 
  src/csi/metrics.cpp PRE-CREATION 
  src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93



Diff: https://reviews.apache.org/r/70245/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message