mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.
Date Tue, 19 Mar 2019 23:07:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213810
-----------------------------------------------------------


Ship it!




LGTM.


3rdparty/cmake/FindZOOKEEPER.cmake
Lines 50 (patched)
<https://reviews.apache.org/r/70233/#comment299871>

    I wonder if it is worth adding a note here, restating bits of the blurb here:
    https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/README#L26-L32
    
    We don't have a note in the autotools build.



cmake/CompilationConfigure.cmake
Lines 115 (patched)
<https://reviews.apache.org/r/70233/#comment299870>

    Using a Windows style path here is... a bit funny to me.  Nothing wrong with it though.


- Joseph Wu


On March 18, 2019, 5:11 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> -----------------------------------------------------------
> 
> (Updated March 18, 2019, 5:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-9662
>     https://issues.apache.org/jira/browse/MESOS-9662
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed for optionally unbundled ZooKeeper for CMake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 
> 
> 
> Diff: https://reviews.apache.org/r/70233/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message