mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 70206: Displayed error message on resource validation failures.
Date Tue, 19 Mar 2019 18:37:42 GMT


> On March 19, 2019, 1:48 p.m., Benjamin Bannier wrote:
> > src/v1/resources.cpp
> > Line 1731 (original), 1731-1733 (patched)
> > <https://reviews.apache.org/r/70206/diff/1/?file=2132246#file2132246line1731>
> >
> >     Let's separate this block by newlines.

Fixed this while merging.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213805
-----------------------------------------------------------


On March 13, 2019, 3:54 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70206/
> -----------------------------------------------------------
> 
> (Updated March 13, 2019, 3:54 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When pushing a reservation, the validation code would not
> print the error that caused validation to fail. This could
> result in developers scratching their heads in confusion.
> 
> 
> Diffs
> -----
> 
>   src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f 
> 
> 
> Diff: https://reviews.apache.org/r/70206/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message