mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70213: Added the `VolumeManager` interface to manage CSI volumes.
Date Tue, 19 Mar 2019 14:42:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70213/#review213806
-----------------------------------------------------------




src/csi/volume_manager.hpp
Lines 74-75 (patched)
<https://reviews.apache.org/r/70213/#comment299834>

    Do we have a chance here to translate from CSI semantics to our own semantics instead
of leaking the CSI protocol? I think not using a magic value of `0` would be nice.
    
    Seems like we could either return a `Failure` if `GET_CAPACITY` is not supported or some
`Option<Bytes>::none()`. This would likely require capability knowledge.



src/csi/volume_manager.hpp
Lines 77 (patched)
<https://reviews.apache.org/r/70213/#comment299841>

    Shouldn't this be version-agnostic?



src/csi/volume_manager.hpp
Lines 104 (patched)
<https://reviews.apache.org/r/70213/#comment299838>

    Ditto.



src/csi/volume_manager.hpp
Lines 112 (patched)
<https://reviews.apache.org/r/70213/#comment299839>

    Ditto.



src/csi/volume_manager.hpp
Lines 115-117 (patched)
<https://reviews.apache.org/r/70213/#comment299840>

    Am I reading correctly that the return boolean is not dynamic and just maps onto whether
the controller has `CREATE_DELETE_VOLUME` or not?



src/csi/volume_manager.cpp
Lines 28-35 (patched)
<https://reviews.apache.org/r/70213/#comment299835>

    How do you plan to dispatch here once we need to support both `v0` and `v1`? Can we infer
what needs to be done from these arguments alone?



src/csi/volume_manager.cpp
Lines 44 (patched)
<https://reviews.apache.org/r/70213/#comment299836>

    `#include <stout/errorbase.hpp>`


- Benjamin Bannier


On March 15, 2019, 6:14 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70213/
> -----------------------------------------------------------
> 
> (Updated March 15, 2019, 6:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `VolumeManager` is a wrapper for SLRP to use v0 and v1 CSI plugins
> polymorphically. It will be managing volume lifecycles and checkpoints
> and making the actual CSI calls for SLRP and SERP in the future.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
>   src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
>   src/csi/volume_manager.hpp PRE-CREATION 
>   src/csi/volume_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70213/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message