mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70206: Displayed error message on resource validation failures.
Date Tue, 19 Mar 2019 13:48:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213805
-----------------------------------------------------------


Fix it, then Ship it!




Finally! I cannot count the number of times I manually patched this into the code when debugging
:D


src/v1/resources.cpp
Line 1731 (original), 1731-1733 (patched)
<https://reviews.apache.org/r/70206/#comment299833>

    Let's separate this block by newlines.


- Benjamin Bannier


On March 13, 2019, 4:54 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70206/
> -----------------------------------------------------------
> 
> (Updated March 13, 2019, 4:54 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When pushing a reservation, the validation code would not
> print the error that caused validation to fail. This could
> result in developers scratching their heads in confusion.
> 
> 
> Diffs
> -----
> 
>   src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f 
> 
> 
> Diff: https://reviews.apache.org/r/70206/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message