mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70230: Made volume gid manager not handle non-shared PV.
Date Mon, 18 Mar 2019 15:24:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70230/#review213778
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70230]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On March 18, 2019, 1:30 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70230/
> -----------------------------------------------------------
> 
> (Updated March 18, 2019, 1:30 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9641
>     https://issues.apache.org/jira/browse/MESOS-9641
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch reverts the following 3 patches which made volume gid manager
> allocate & deallocate gid to non-shared PV.
>   https://reviews.apache.org/r/70137/
>   https://reviews.apache.org/r/70139/
>   https://reviews.apache.org/r/70140/
> 
> We want to keep the original behavior of non-shared PV, i.e., change its
> owner to the task user, so that the task can fully control the volume,
> i.e., the task can not only access the volume but also change its
> metadata like changing the permissions of the volume (`chmod`).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 725754f26855ea54ccf8cbcb288ee3b29e8ed4e7

>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25

>   src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 60e9ae5970a0a45314d0b3569556bef36d350d2b

>   src/tests/persistent_volume_tests.cpp 7e929a5a3a92e16a5dec10206f37caebc20d66a8 
> 
> 
> Diff: https://reviews.apache.org/r/70230/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message