mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70165: Fixed operator operation handling with resource provider resources.
Date Mon, 18 Mar 2019 12:09:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70165/#review213771
-----------------------------------------------------------



Thanks for the fixes, this looks good now.

I raised an issue about a possible race where the framework would never see the expected offer.
Like you explained to me offline, this is an issue with other tests following the same pattern
as well. @chhsia0, can you see how this could be fixed in general? Added another flaky test
doesn't sound good to me.


src/resource_provider/manager.cpp
Line 512 (original), 525-526 (patched)
<https://reviews.apache.org/r/70165/#comment299758>

    Nit:
    ```
    << " to resource provider " << resourceProviderId.get()
    << ": connection closed";
    ```



src/tests/storage_local_resource_provider_tests.cpp
Lines 5480 (patched)
<https://reviews.apache.org/r/70165/#comment299762>

    Thanks for adding these, I think the tests very well now.



src/tests/storage_local_resource_provider_tests.cpp
Lines 5496 (patched)
<https://reviews.apache.org/r/70165/#comment299761>

    Even though above we wait for the second `UpdateSlaveMessage` we might still never get
the offers we expect here.
    
    I was able to break this test with `stress-ng` in less than 100 iterations. /cc @chun


- Benjamin Bannier


On March 11, 2019, 10:42 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70165/
> -----------------------------------------------------------
> 
> (Updated March 11, 2019, 10:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9612
>     https://issues.apache.org/jira/browse/MESOS-9612
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The resource provider manager didn't allow operations originating from
> operator API calls. For speculatively applied operations, this is
> allowed now.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f 
>   src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f

> 
> 
> Diff: https://reviews.apache.org/r/70165/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message