mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.
Date Mon, 18 Mar 2019 04:44:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review213769
-----------------------------------------------------------



PASS: Mesos patch 70225 was successfully built and tested.

Reviews applied: `['70168', '70169', '70213', '70214', '70215', '70216', '70217', '70222',
'70223', '70225']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2973/mesos-review-70225

- Mesos Reviewbot Windows


On March 16, 2019, 12:40 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
> 
> (Updated March 16, 2019, 12:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9639
>     https://issues.apache.org/jira/browse/MESOS-9639
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 2c2320ad01a5f46a5253c880d34a1c9ac6cf4ca4 
>   src/csi/metrics.hpp PRE-CREATION 
>   src/csi/metrics.cpp PRE-CREATION 
>   src/csi/service_manager.cpp PRE-CREATION 
>   src/csi/v0_volume_manager.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f

> 
> 
> Diff: https://reviews.apache.org/r/70225/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message