mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 70217: Implemented the remain functionalities for v0 `VolumeManager`.
Date Mon, 18 Mar 2019 02:53:57 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 18, 2019, 2:53 a.m.)

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Fixed the "narrowing conversion" compilation error on Windows.

Bugs: MESOS-9622

Repository: mesos

Description (updated)

This patch completes the `listVolumes`, `getCapacity`, `createVolume`,
`deleteVolume` and `validateVolume` methods for the v0 `VolumeManager`.
Compared to SLRP, `VolumeManager` now supports validating a volume that
has already been mounted (say before the agent ID changes), as well as
deleting unmanaged volumes.

Diffs (updated)

  src/csi/v0_volume_manager.cpp PRE-CREATION 
  src/csi/v0_volume_manager_process.hpp PRE-CREATION 




make check


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message