mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 70215: Implemented volume attachment and publishment for v0 `VolumeManager`.
Date Fri, 15 Mar 2019 23:39:00 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 15, 2019, 11:38 p.m.)

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Added missing headers and adjusted comments.

Bugs: MESOS-9622

Repository: mesos


The attachment and publishment are implemented with internal helpers,
each individually deals with one steady and two transient states and
makes a proper CSI call to achieve its goal state. If the given volume
is not in the designed state, it would recursively call other helpers
to transition the volume to the designed state first.

These helper functions are sequentialized through the volume's own
sequence in the public-facing functions to avoid racing operations on
the same volume.

Diffs (updated)

  src/csi/v0_volume_manager.cpp PRE-CREATION 
  src/csi/v0_volume_manager_process.hpp PRE-CREATION 




make check


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message