mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 70208: Added test for reconciliation of multiple operations.
Date Fri, 15 Mar 2019 23:10:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213756
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/operation_reconciliation_tests.cpp
Lines 284-293 (patched)
<https://reviews.apache.org/r/70208/#comment299748>

    We could remove this if the first operation also reserved 0.1 CPUs


- Gastón Kleiman


On March 15, 2019, 3:53 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> -----------------------------------------------------------
> 
> (Updated March 15, 2019, 3:53 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9648
>     https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for reconciliation of multiple operations.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0

> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/2/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message