mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70161: Added validation for `QuotaConfig`.
Date Fri, 15 Mar 2019 00:11:21 GMT


> On March 13, 2019, 12:23 p.m., Benjamin Mahler wrote:
> > src/master/quota.cpp
> > Lines 323-349 (patched)
> > <https://reviews.apache.org/r/70161/diff/2/?file=2131820#file2131820line323>
> >
> >     At first I thought there was a missing closing / opening single quotes on these,
maybe we should use braces?
> >     
> >     ```
> >     Invalid guarantee configuration {'cpus': NaN}: NaN not supported
> >     ```

Done.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70161/#review213680
-----------------------------------------------------------


On March 12, 2019, 11:41 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70161/
> -----------------------------------------------------------
> 
> (Updated March 12, 2019, 11:41 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9596
>     https://issues.apache.org/jira/browse/MESOS-9596
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A `QuotaConfig` is valid if the following conditions are met:
> 
>  (1) The config has a valid non-"*" role.
> 
>  (2) Resource scalar values are non-negative and finite.
> 
>  (3) If both guarantees and limits are set for a particular
>      resource, then guarantee <= limit for that resource.
> 
> 
> Diffs
> -----
> 
>   src/master/quota.hpp 5cd2bb0e8669ee0290a4c1fe1058b87251772939 
>   src/master/quota.cpp 671626c01ada595d7557d5266e39a17cce243b94 
> 
> 
> Diff: https://reviews.apache.org/r/70161/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> dedicated test added in subsequent patches
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message