-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213732
-----------------------------------------------------------
Could you also update a test to verify that metrics transition correctly? i.e., that operation
metrics will start at `pending == 0` and `finished == 0`, then transition to `pending == 1`
and `finished == 0`, then finally to `pending == 0` and `finished == 1`? Would be nice to
do this for both the global and per-operation metrics.
src/tests/persistent_volume_endpoints_tests.cpp
Line 1681 (original), 1683-1686 (patched)
<https://reviews.apache.org/r/70117/#comment299711>
Nit: too many newlines.
- Greg Mann
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:01 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
|