mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70201: Added a method to check `ResourceLimits::contains(ResourceQuantities)`.
Date Wed, 13 Mar 2019 19:37:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213682
-----------------------------------------------------------


Ship it!





src/common/resource_quantities.cpp
Lines 406-418 (patched)
<https://reviews.apache.org/r/70201/#comment299682>

    This is very clean and readable! I guess we're ok with the re-scanning approach instead
of walking both alphabetically for now?
    
    (I think it's fine, we can consider optimizing it later if needed)



src/common/resource_quantities.cpp
Lines 408-409 (patched)
<https://reviews.apache.org/r/70201/#comment299681>

    How about s/quantityScalar/quantity/ ?
    
    Also fits cleanly on one line that way:
    
    ```
    >>> len(' foreachpair (const string& name, const Value::Scalar& quantity,
quantities) {')
    78
    ```



src/tests/resource_quantities_tests.cpp
Lines 434-473 (patched)
<https://reviews.apache.org/r/70201/#comment299683>

    This was easy to read, thanks!


- Benjamin Mahler


On March 13, 2019, 2:13 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> -----------------------------------------------------------
> 
> (Updated March 13, 2019, 2:13 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added tests.
> 
> 
> Diffs
> -----
> 
>   src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
>   src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
>   src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b 
> 
> 
> Diff: https://reviews.apache.org/r/70201/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message