mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.
Date Wed, 13 Mar 2019 19:29:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70203/#review213681
-----------------------------------------------------------


Ship it!




Nice!


src/tests/master_validation_tests.cpp
Lines 307-308 (original), 164-165 (patched)
<https://reviews.apache.org/r/70203/#comment299680>

    Do we want the extra spaces after { and before }?


- Benjamin Mahler


On March 13, 2019, 6:46 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70203/
> -----------------------------------------------------------
> 
> (Updated March 13, 2019, 6:46 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9596
>     https://issues.apache.org/jira/browse/MESOS-9596
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated a test for `UPDATE_QUOTA` call validation.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp 9568d39accb00eec68b622fdc7f02249fefbc063 
> 
> 
> Diff: https://reviews.apache.org/r/70203/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message