mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70168: Added `ServiceManager` to manage CSI plugin container lifecycles.
Date Tue, 12 Mar 2019 18:59:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/
-----------------------------------------------------------

(Updated March 12, 2019, 6:59 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Removed unnecessary namespace qualifications, named the actor, and let the set of services
be specified.


Bugs: MESOS-9632
    https://issues.apache.org/jira/browse/MESOS-9632


Repository: mesos


Description
-------

The `ServiceManager` is agnostic to CSI versions, so can be used to
manage plugin containers for both CSI v0 and v1 plugins. Most of its
logic are adapted from the SLRP code.

We also separate the CSI plugin metrics from SLRP metrics object so the
metrics can be accessed by `ServiceManager`. However, we do not make
`ServiceManager` own the CSI plugin metrics object because eventually we
would like to decouple metrics lifecycles from SLRP lifecycles.


Diffs (updated)
-----

  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
  src/csi/metrics.hpp PRE-CREATION 
  src/csi/metrics.cpp PRE-CREATION 
  src/csi/service_manager.hpp PRE-CREATION 
  src/csi/service_manager.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/70168/diff/4/

Changes: https://reviews.apache.org/r/70168/diff/3-4/


Testing
-------

Testing done later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message