mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 70183: Made setting volume ownership asynchronous.
Date Tue, 12 Mar 2019 05:07:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70183/#review213617
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On March 11, 2019, 8:03 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70183/
> -----------------------------------------------------------
> 
> (Updated March 11, 2019, 8:03 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9643
>     https://issues.apache.org/jira/browse/MESOS-9643
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Setting volume ownership can be expensive because we need to traverse
> all the directories and files in it. So in this patch we make setting
> volume ownership asynchronous which will improve the performance in
> the following cases:
>   1. Launching a container which uses two difererent volumes.
>   2. Launching two containers simultaneously which use two different
>      volumes respectively.
>   3. Launching a container which uses a volume while another task which
>      uses a volume is being destroyed, and vice versa.
> 
> 
> Diffs
> -----
> 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp c0fc1db24760e691214de991529f8963faf597f4

> 
> 
> Diff: https://reviews.apache.org/r/70183/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message