mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70069: Improved `ResourceQuantities` test's readability.
Date Mon, 11 Mar 2019 22:22:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70069/#review213600
-----------------------------------------------------------


Ship it!





src/tests/resource_quantities_tests.cpp
Lines 46 (patched)
<https://reviews.apache.org/r/70069/#comment299579>

    Maybe?
    
    const auto& q
    
    auto&&


- Benjamin Mahler


On Feb. 28, 2019, 1:21 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70069/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2019, 1:21 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved `ResourceQuantities` test's readability.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b 
> 
> 
> Diff: https://reviews.apache.org/r/70069/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message