mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 70171: Added `Try` constructors from `_Some`.
Date Sat, 09 Mar 2019 01:56:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70171/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Repository: mesos


Description
-------

This is necessary in cases such as constructing
`Result<T>` from `T`:
```
  Result(const T& _t)
    : data(Some(_t)) {}
```
to avoid unnecessary implicit conversions and copies.


Diffs
-----

  3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444 


Diff: https://reviews.apache.org/r/70171/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message