mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70132: Do not implicitly refuse speculatively converted resources.
Date Fri, 08 Mar 2019 00:23:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70132/
-----------------------------------------------------------

(Updated March 8, 2019, 12:23 a.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Addressed BenM's comments.


Bugs: MESOS-9616
    https://issues.apache.org/jira/browse/MESOS-9616


Repository: mesos


Description
-------

Currently if a framework accepts an offer to perform pipelined
operations, e.g., reserving resource, without a final consumer, the
converted resources will be implicitly refused. This is an undesired
behavior as the framework might want to reserve one resource first but
launch a task later in the next allocation cycle. This patch fixes this
behavior.

But, if the framework accepts an offers with multiple operations that
cancel out each other, the resources consumed by these operations are
still considered unused and will be refused.


Diffs (updated)
-----

  docs/scheduler-http-api.md 8384336bbecf2ca38a3cd203f9db28d931812d65 
  src/master/master.cpp b9db4ffd4ee8ea4a8e44a35d1afb6c1b8e03d74d 
  src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843 


Diff: https://reviews.apache.org/r/70132/diff/3/

Changes: https://reviews.apache.org/r/70132/diff/2-3/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message