mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70123: Added rvalue overload for `Result::get()`.
Date Thu, 07 Mar 2019 17:40:27 GMT


> On March 5, 2019, 10:09 p.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/result.hpp
> > Lines 129 (patched)
> > <https://reviews.apache.org/r/70123/diff/2/?file=2128782#file2128782line129>
> >
> >     ```
> >     -> decltype(std::forward<Self>(self)
> >                   .data
> >                   .get() // NOLINT(mesos-redundant-get)
> >                   .get())
> >     ```
> >     
> >     See below.

Can't we just use two star operators here given the other outstanding patches?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70123/#review213433
-----------------------------------------------------------


On March 4, 2019, 11:53 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70123/
> -----------------------------------------------------------
> 
> (Updated March 4, 2019, 11:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added rvalue overload for `Result::get()`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3 
> 
> 
> Diff: https://reviews.apache.org/r/70123/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message