mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 70099: Parameterized cpplint extension list via config instead of via patch.
Date Wed, 06 Mar 2019 13:25:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70099/#review213477
-----------------------------------------------------------




support/mesos-style.py
Line 266 (original), 266 (patched)
<https://reviews.apache.org/r/70099/#comment299418>

    This might reduce the files we check, and it's not reflected in the summary. May I ask
you to either extract it into a separate patch or update the summary?


- Alexander Rukletsov


On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70099/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 1:02 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Parameterized cpplint extension list via config instead of via patch.
> 
> 
> Diffs
> -----
> 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
>   support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 
> 
> 
> Diff: https://reviews.apache.org/r/70099/diff/1/
> 
> 
> Testing
> -------
> 
> ./support/mesos-style.py
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message