mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 70098: Made cpplint.patch reflect our modifications.
Date Wed, 06 Mar 2019 10:46:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70098/#review213470
-----------------------------------------------------------



Looking at this deeper, I'm not sure we should explicitly maintain the patch. Of course, ideally
we would have a copy of a specific version of cpplint plus the patch, but it is unclear when
to apply the patch (on bootstrap? on build?). To make things simpler and have only one source
of truth, let's **remove** the patch altogether and leave a comment in the **modified** version
of `cpplint.py` with 1) SHA of the base `cpplint.py` to be able to restore the diff and 2)
a quick overview of our modifications.


support/cpplint.patch
Lines 1-4 (original), 1-4 (patched)
<https://reviews.apache.org/r/70098/#comment299402>

    These are not whitespace changes : )


- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70098/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch was created by performing a `git diff` of our current
> version agains our upstream version `43d512ba130`.
> 
> This patch restores trailing but significant whitespaces to the patch
> file, which are flagged by our commit hooks. When committing we need to
> skip these hooks.
> 
> 
> Diffs
> -----
> 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
> 
> 
> Diff: https://reviews.apache.org/r/70098/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message