mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70131: Added a comment around recovery for `ContainerLogger`s.
Date Wed, 06 Mar 2019 07:35:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70131/#review213464
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70131]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On March 5, 2019, 10:42 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70131/
> -----------------------------------------------------------
> 
> (Updated March 5, 2019, 10:42 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `ContainerLogger` interface does not currently use a
> "prepare-recover-cleanup" pattern and hence neither allows
> stateful loggers nor provides synchronization on container
> termination. Capture this in a comment to the interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp 4e6d15a503e533a82bfac393da447f6f129dd66d 
> 
> 
> Diff: https://reviews.apache.org/r/70131/diff/1/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message