mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 70131: Added a comment around recovery for `ContainerLogger`s.
Date Tue, 05 Mar 2019 22:42:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70131/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Joseph Wu, and Till Toenshoff.


Repository: mesos


Description
-------

`ContainerLogger` interface does not currently use a
"prepare-recover-cleanup" pattern and hence neither allows
stateful loggers nor provides synchronization on container
termination. Capture this in a comment to the interface.


Diffs
-----

  include/mesos/slave/container_logger.hpp 4e6d15a503e533a82bfac393da447f6f129dd66d 


Diff: https://reviews.apache.org/r/70131/diff/1/


Testing
-------

None: not a functional change.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message