mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 67762: Added minimum capability check during master recovery.
Date Tue, 05 Mar 2019 18:53:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67762/
-----------------------------------------------------------

(Updated March 5, 2019, 10:53 a.m.)


Review request for mesos, Benjamin Mahler and Joseph Wu.


Changes
-------

Fixed the commit message.


Bugs: MESOS-8880
    https://issues.apache.org/jira/browse/MESOS-8880


Repository: mesos


Description (updated)
-------

Upon recovery, the master will compare its own capabilities against the
list of strings read from the registry.  If the master is missing any
of the capabilities read from the registry, the master will refuse to
recover and try to provide remediation steps instead.

Modifications to the registry's list will be added in future, within
the logic for other RegistryOperations.  For example, if support for
Quota limit bursting (MESOS-8068) is added to a future master,
setting a quota limit should cause the UpdateQuota RegistryOperation
to add the appropriate minimum capability.  A RemoveQuota
RegistryOperation would remove the minimum capability if there are no
other quota limits in use.

Also adds a dedicated test.


Diffs (updated)
-----

  include/mesos/mesos.proto 48f30b3f41f3440245c1912becc9c2c3d572aff9 
  include/mesos/v1/mesos.proto e07dd9e42939fddcff5d15072a143d9c4c44dd3d 
  src/master/master.hpp aceab3455adfdf7ff6e168e033316997a4d36fb5 
  src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5 
  src/tests/master_tests.cpp 5ae8e1cea3ca87551093bd63d744ac807ac7797a 


Diff: https://reviews.apache.org/r/67762/diff/6/

Changes: https://reviews.apache.org/r/67762/diff/5-6/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message