mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 70108: Added `unconfined` flag to `SeccompInfo` message.
Date Tue, 05 Mar 2019 14:31:11 GMT


> On March 5, 2019, 7:29 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp
> > Line 104 (original), 107 (patched)
> > <https://reviews.apache.org/r/70108/diff/1/?file=2128574#file2128574line107>
> >
> >     not from this patch:
> >     
> >     return Failure("Failed to parse profile for container " + containerId + ": "
+ customProfile.error());

We don't need to mention `containerId` in failure messages. See my previous comment https://reviews.apache.org/r/68021/#comment297568


> On March 5, 2019, 7:29 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp
> > Line 109 (original), 114 (patched)
> > <https://reviews.apache.org/r/70108/diff/1/?file=2128574#file2128574line114>
> >
> >     Not from this patch, but we should print out the containerID for debugging:
> >     
> >     "Failed to prepare container " + containerId + ": Missing Seccomp profile name"

We don't need to mention `containerId` in failure messages. See my previous comment https://reviews.apache.org/r/68021/#comment297568


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70108/#review213426
-----------------------------------------------------------


On March 4, 2019, 2:03 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70108/
> -----------------------------------------------------------
> 
> (Updated March 4, 2019, 2:03 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-9613
>     https://issues.apache.org/jira/browse/MESOS-9613
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces `unconfined` flag that can be used by a framework
> to explicitly disable Seccomp filtering for a particular container.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 48f30b3f41f3440245c1912becc9c2c3d572aff9 
>   include/mesos/v1/mesos.proto e07dd9e42939fddcff5d15072a143d9c4c44dd3d 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 1c94e126a0a5039e46d0e7696f4e629d41b35d50

> 
> 
> Diff: https://reviews.apache.org/r/70108/diff/2/
> 
> 
> Testing
> -------
> 
> See the following patch in the chain.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message