mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 70114: Added logging for `linux/seccomp` isolator.
Date Tue, 05 Mar 2019 07:32:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70114/#review213428
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/linux/seccomp.cpp
Lines 110-111 (patched)
<https://reviews.apache.org/r/70114/#comment299367>

    I would probably move it down to L126 for print the path for all seccomp profile cases.


- Gilbert Song


On March 4, 2019, 6:59 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70114/
> -----------------------------------------------------------
> 
> (Updated March 4, 2019, 6:59 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added logging for `linux/seccomp` isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 1c94e126a0a5039e46d0e7696f4e629d41b35d50

> 
> 
> Diff: https://reviews.apache.org/r/70114/diff/1/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message