mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks.
Date Tue, 05 Mar 2019 05:05:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69970/
-----------------------------------------------------------

(Updated March 5, 2019, 5:05 a.m.)


Review request for mesos, Benjamin Bannier and Jan Schlicht.


Changes
-------

Added a TODO, as suggested by Benjamin.


Bugs: MESOS-9568
    https://issues.apache.org/jira/browse/MESOS-9568


Repository: mesos


Description
-------

When the SLRP stage/publish a CSI volume, it creates the staging/target
paths, but only the target path is cleaned up during unpublish.
Moreover, even if the CSI plugin does not support node-staging, the
current cleanup is still not enough, as the parent directory of the
target path is not removed. This patch fixes this problem.


Diffs (updated)
-----

  src/csi/paths.hpp 7a4e9e0e85ca33c8be0a16ff4531c765f40e0adc 
  src/csi/paths.cpp 772d960d96d481949cf25bc464e39e1ec15cd27d 
  src/resource_provider/storage/provider.cpp 7a1b1d9688e63560e6157320430d4d02da3b94a6 
  src/resource_provider/storage/provider_process.hpp 2ba24ae692fd29530173312949b395265f705ae7



Diff: https://reviews.apache.org/r/69970/diff/3/

Changes: https://reviews.apache.org/r/69970/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message