mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.
Date Mon, 04 Mar 2019 22:50:51 GMT


> On March 4, 2019, 4:45 a.m., Benjamin Bannier wrote:
> > 3rdparty/stout/include/stout/option.hpp
> > Lines 129-130 (patched)
> > <https://reviews.apache.org/r/70067/diff/3/?file=2127549#file2127549line129>
> >
> >     Not sure this comment adds much value since it just restates what is already
in code.

Removed. Ditto below.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70067/#review213393
-----------------------------------------------------------


On March 4, 2019, 2:50 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70067/
> -----------------------------------------------------------
> 
> (Updated March 4, 2019, 2:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7124
>     https://issues.apache.org/jira/browse/MESOS-7124
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added star operator for `Result`, `Try` and `Option`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/option.hpp 8feed012a55fed6eab89c883958324f3345e46e9 
>   3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3 
>   3rdparty/stout/include/stout/try.hpp 30cce7e27fa040d0ce5a86efc4820f8c39178444 
>   3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c 
>   3rdparty/stout/tests/result_tests.cpp 1750e6b4a90afec3b7de0621779f8b69a856da41 
>   3rdparty/stout/tests/try_tests.cpp 99b7b2a3f968abb87549fb9075d65bc5bcc827f1 
> 
> 
> Diff: https://reviews.apache.org/r/70067/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message