mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70116: Added metrics for offer operation feedback.
Date Mon, 04 Mar 2019 22:45:15 GMT


> On March 4, 2019, 10:20 p.m., Greg Mann wrote:
> > src/master/metrics.hpp
> > Lines 63-67 (patched)
> > <https://reviews.apache.org/r/70116/diff/1/?file=2128637#file2128637line63>
> >
> >     Is this comment accurate? Looks like there is indeed an `operations_unreachable`
metric below.
> >     
> >     I think we could probably skip the metrics for such states as the comment suggests.

I think that `operations_recovering`, `operations_unreachable`, and `operations_gone_by_operator`
could be removed, since those metrics would not be accurate after a master failover (i.e.,
master won't know how many operations were on an agent which was marked GONE after master
failover). I think the other metrics still make sense.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70116/#review213404
-----------------------------------------------------------


On March 4, 2019, 5:01 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70116/
> -----------------------------------------------------------
> 
> (Updated March 4, 2019, 5:01 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8241
>     https://issues.apache.org/jira/browse/MESOS-8241
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds the following additional metrics
> to the master:
> 
>     - master/operations_pending
>     - master/operations_recovering
>     - master/operations_finished
>     - master/operations_failed
>     - master/operations_error
>     - master/operations_dropped
>     - master/operations_unreachable
>     - master/operations_gone_by_operator
> 
> Unit tests are added in the subsequent commit.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp aceab3455adfdf7ff6e168e033316997a4d36fb5 
>   src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5 
>   src/master/metrics.hpp 4495e65b6bb11f7236335a702c4f61e7c3f9b0aa 
>   src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9 
> 
> 
> Diff: https://reviews.apache.org/r/70116/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message