mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks.
Date Mon, 04 Mar 2019 20:22:43 GMT


> On Feb. 27, 2019, 2:53 p.m., Benjamin Bannier wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 975-980 (patched)
> > <https://reviews.apache.org/r/69970/diff/1/?file=2125063#file2125063line975>
> >
> >     This almost seems like a hard error to me (but would introduce coupling). Maybe
just inline the function here and possibly assert.
> 
> Chun-Hung Hsiao wrote:
>     This definitely means the csidir is somehow "damaged." But the agent can operate
without it, and the failure would fail the recovery and terminate the SLRP in the `recover()`
function.
> 
> Benjamin Bannier wrote:
>     It seems that since this SLRP are currently effectively an agent component, failing
hard here could make sense. How else would a user detect such damaged state and recover it?
> 
> Chun-Hung Hsiao wrote:
>     Would it make sense to address this problem more generally through https://issues.apache.org/jira/browse/MESOS-8745?

Yes, probably, but not ideal either as this would be triggered not by users performing an
action with invalid state, by by our own state somehow becoming "damaged".

Let's add a `TODO` here referencing the issue to document this in the code. Dropping the issue.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69970/#review213255
-----------------------------------------------------------


On Feb. 28, 2019, 3:31 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69970/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2019, 3:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9568
>     https://issues.apache.org/jira/browse/MESOS-9568
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the SLRP stage/publish a CSI volume, it creates the staging/target
> paths, but only the target path is cleaned up during unpublish.
> Moreover, even if the CSI plugin does not support node-staging, the
> current cleanup is still not enough, as the parent directory of the
> target path is not removed. This patch fixes this problem.
> 
> 
> Diffs
> -----
> 
>   src/csi/paths.hpp 7a4e9e0e85ca33c8be0a16ff4531c765f40e0adc 
>   src/csi/paths.cpp 772d960d96d481949cf25bc464e39e1ec15cd27d 
>   src/resource_provider/storage/provider.cpp 7a1b1d9688e63560e6157320430d4d02da3b94a6

>   src/resource_provider/storage/provider_process.hpp 2ba24ae692fd29530173312949b395265f705ae7

> 
> 
> Diff: https://reviews.apache.org/r/69970/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message