mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider.
Date Mon, 04 Mar 2019 11:47:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70081/#review213392
-----------------------------------------------------------


Ship it!




LGTM. Would be great if we could address https://reviews.apache.org/r/70081/#comment_rc299292-213391
before merging.

- Benjamin Bannier


On March 2, 2019, 12:46 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70081/
> -----------------------------------------------------------
> 
> (Updated March 2, 2019, 12:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9607
>     https://issues.apache.org/jira/browse/MESOS-9607
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `Slave::publishResources` will no longer ask all resource providers to
> publish all allocated resources. Instead, it only asks those of the
> task's resources to publish resources, so a failed resource provider
> would only fail tasks that want to use its resources.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 2cde62a1849b7d595841fb845033640b537b844d 
>   src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02 
>   src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 
> 
> 
> Diff: https://reviews.apache.org/r/70081/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message