mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.
Date Mon, 04 Mar 2019 02:30:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213381
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70095, 70096, 70097, 70098, 70099, 70100, 70101, 70102]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On March 3, 2019, 9:02 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 9:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -----
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message