mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70104: Fixed broken Yaml in contributors database.
Date Sun, 03 Mar 2019 21:24:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70104/#review213377
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70104]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On March 3, 2019, 1:29 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70104/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 1:29 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch also removes the executable bit on this file which was
> added in the same commit as the invalid Yaml.
> 
> 
> Diffs
> -----
> 
>   docs/contributors.yaml 171c09118c5c4847660db6cb035dba821c5d92ad 
> 
> 
> Diff: https://reviews.apache.org/r/70104/diff/2/
> 
> 
> Testing
> -------
> 
> * without this patch the changed file fails to validate with pyyaml
> * with this patch all yaml files in the source tree validate with pyyaml
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message