mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70092: Updated to pylint-2.3.0.
Date Sun, 03 Mar 2019 10:36:31 GMT


> On March 3, 2019, 9:25 a.m., Armand Grillet wrote:
> > support/mesos-style.py
> > Lines 251 (patched)
> > <https://reviews.apache.org/r/70092/diff/1/?file=2128265#file2128265line251>
> >
> >     Why is this necessary? The directory `.tox` should mainly have `.py` and `.pyc`
but no C++ source files.

You are correct, not needed here ATM, removing.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213364
-----------------------------------------------------------


On March 3, 2019, 11:36 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 11:36 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated to pylint-2.3.0.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
> 
> 
> Diff: https://reviews.apache.org/r/70092/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> This currently triggers MESOS-9629 if one invokes a linter. It does not fail `make check`
unless we implement MESOS-9628.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message