mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69588: Removed outdated authorization logic for offer operations.
Date Sun, 03 Mar 2019 06:05:32 GMT


> On Jan. 15, 2019, 7:27 p.m., Benjamin Mahler wrote:
> > src/master/master.cpp
> > Line 3818 (original), 3826-3829 (patched)
> > <https://reviews.apache.org/r/69588/diff/2/?file=2115120#file2115120line3839>
> >
> >     Can you use `Resources::reservationRole` for this? I guess `*` is invalid for
persistent volumes but we don't care here?

Right. `*` is invalid for persistent volumes. But we used to still send out a authorization
request before validating the operation. Given that this is an experimental feature, should
we ignore the resource here instead?


> On Jan. 15, 2019, 7:27 p.m., Benjamin Mahler wrote:
> > src/master/master.cpp
> > Lines 3877-3880 (original), 3892-3895 (patched)
> > <https://reviews.apache.org/r/69588/diff/2/?file=2115120#file2115120line3905>
> >
> >     ditto `Resources::reservationRole` and `*` being invalid, but I guess we don't
care here?

We do care about this case, as `CREATE_DISK` can be applied to an unreserved `RAW` disk.


> On Jan. 15, 2019, 7:27 p.m., Benjamin Mahler wrote:
> > src/master/master.cpp
> > Lines 3940-3943 (original), 3959-3962 (patched)
> > <https://reviews.apache.org/r/69588/diff/2/?file=2115120#file2115120line3972>
> >
> >     Ditto `Resources::reservationRole` and `*` being invalid (but I guess we don't
care here?)

See above.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69588/#review212027
-----------------------------------------------------------


On Dec. 19, 2018, 11:20 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69588/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2018, 11:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Michael Park, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the master now upgrades resources to the post-reservation-refinement
> format before authorization (see MESOS-7735), the authorization logic in the
> master becomes outdated. This patch cleans it up.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 
> 
> 
> Diff: https://reviews.apache.org/r/69588/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message