mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 70088: Initialized pointers with `nullptr` instead of `0`.
Date Sun, 03 Mar 2019 02:36:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70088/#review213358
-----------------------------------------------------------


Ship it!




I'm not sure that `nullptr` makes any difference here. Both structs contain both pointer and
integer types, so while `0` is ok, I guess `nullptr` does the job too :)

- James Peach


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70088/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initialized pointers with `nullptr` instead of `0`.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.cpp 4d163818192d8638b9beadbae3250755c5d9fecf 
> 
> 
> Diff: https://reviews.apache.org/r/70088/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message