mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.
Date Sat, 02 Mar 2019 17:08:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54987/#review213352
-----------------------------------------------------------


Ship it!




Simply documenting these is an improvement, so I'm in favor of landing. However, I also think
that a short description of each kind of event would be helpful since the distinctions between
the differnt event queue elements won't be obvious to a new Mesos operator.

- James Peach


On April 30, 2018, 9:09 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54987/
> -----------------------------------------------------------
> 
> (Updated April 30, 2018, 9:09 p.m.)
> 
> 
> Review request for mesos, Eric Chung, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-6831
>     https://issues.apache.org/jira/browse/MESOS-6831
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `docs/monitoring/md` for new agent event queue metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb 
> 
> 
> Diff: https://reviews.apache.org/r/54987/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message