mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70084: Avoid dereferencing removed executors and launching containers for them.
Date Sat, 02 Mar 2019 00:08:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70084/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jie Yu, Meng Zhu, and Vinod Kone.


Bugs: MESOS-8467
    https://issues.apache.org/jira/browse/MESOS-8467


Repository: mesos


Description
-------

When launching executors and tasks, there is no guarantee that the
executors still remain after `Slave::publishResources` is returned. If
not, the executor struct should not be dereferenced and the executor
containers should not be launched at all.

NOTE: The patch makes `Slave::launchExecutor` called asynchronously even
if there is a secret generator or not. However this should not affect
the correctness of executor launching.


Diffs
-----

  src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02 
  src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 


Diff: https://reviews.apache.org/r/70084/diff/1/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message