mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70082: Used `id::UUID` to index publishing requests in the RP manager.
Date Fri, 01 Mar 2019 23:01:06 GMT


> On March 1, 2019, 10:17 p.m., Benjamin Bannier wrote:
> > This does not look wrong to me, but with just at this patch and its chain it isn't
really clear what exactly is _better_ with this approach. Could you expand the commit message?
Such information is valuable when trying to decide in the future whether certain behavior
is needed or just nice.

I'll reorder the patches. This one is just nice and consistent but not needed.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70082/#review213336
-----------------------------------------------------------


On March 1, 2019, 8:10 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70082/
> -----------------------------------------------------------
> 
> (Updated March 1, 2019, 8:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9607
>     https://issues.apache.org/jira/browse/MESOS-9607
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using `id::UUID` instead of the `UUID` protobuf gives us better
> validation on the UUID format.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 2cde62a1849b7d595841fb845033640b537b844d 
> 
> 
> Diff: https://reviews.apache.org/r/70082/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message