mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70082: Used `id::UUID` to index publishing requests in the RP manager.
Date Fri, 01 Mar 2019 22:17:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70082/#review213336
-----------------------------------------------------------


Fix it, then Ship it!




This does not look wrong to me, but with just at this patch and its chain it isn't really
clear what exactly is _better_ with this approach. Could you expand the commit message? Such
information is valuable when trying to decide in the future whether certain behavior is needed
or just nice.


src/resource_provider/manager.cpp
Line 974 (original), 984 (patched)
<https://reviews.apache.org/r/70082/#comment299291>

    We could introduce a `const id::UUID& uuid_` right after returning for the error state.


- Benjamin Bannier


On March 1, 2019, 9:10 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70082/
> -----------------------------------------------------------
> 
> (Updated March 1, 2019, 9:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9607
>     https://issues.apache.org/jira/browse/MESOS-9607
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using `id::UUID` instead of the `UUID` protobuf gives us better
> validation on the UUID format.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 2cde62a1849b7d595841fb845033640b537b844d 
> 
> 
> Diff: https://reviews.apache.org/r/70082/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message