mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 70049: Assured a set USER within RPM build.
Date Fri, 01 Mar 2019 09:52:32 GMT


> On Feb. 28, 2019, 8:52 p.m., Benjamin Bannier wrote:
> > support/packaging/centos/build_rpm.sh
> > Lines 29 (patched)
> > <https://reviews.apache.org/r/70049/diff/1/?file=2126568#file2126568line29>
> >
> >     What about only setting this if unset?
> >     
> >         export USER=${USER:-centos}
> >         
> >     That way this script would do the expected thing if invoked by somebody building
her own packages, and we wouldn't necessarily assume that we run this in a Docker container.

magificient.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70049/#review213309
-----------------------------------------------------------


On Feb. 25, 2019, 2:31 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70049/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2019, 2:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9605
>     https://issues.apache.org/jira/browse/MESOS-9605
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Assured a set USER within RPM build.
> 
> 
> Diffs
> -----
> 
>   support/packaging/centos/build_rpm.sh 4c5b9617cfcef591b33d11f7f84170c0781d1fa1 
> 
> 
> Diff: https://reviews.apache.org/r/70049/diff/1/
> 
> 
> Testing
> -------
> 
> Installed resulting package and ran agent;
> ```
> [root@9b0d899ff4c6 ~]# mesos-slave --work_dir=/tmp --master=127.0.0.1:5050
> I0225 02:30:16.113528    97 main.cpp:350] Build: 2019-02-25 01:59:55 by centos
> I0225 02:30:16.113606    97 main.cpp:351] Version: 1.8.0
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message