mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.
Date Tue, 19 Mar 2019 16:17:01 GMT
asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between
Type and *Infos in the ContainerInfo.
URL: https://github.com/apache/mesos/pull/326#discussion_r266975318
 
 

 ##########
 File path: src/common/protobuf_utils.cpp
 ##########
 @@ -77,6 +77,56 @@ namespace mesos {
 namespace internal {
 namespace protobuf {
 
+
+UnionValidator::UnionValidator(
+  const google::protobuf::Descriptor* descriptor,
+  const google::protobuf::EnumDescriptor* typeDescriptor)
+{
+  typeDescriptor_ = typeDescriptor;
+  const auto* unknownTypeValueDescriptor = typeDescriptor->FindValueByNumber(0);
 
 Review comment:
   Now it should be much more clear from the code of the UnionValidator constructor to which
field the typeDescriptor corresponds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message